페이지 기능: 로그인 이후 토큰 인증에 따라 로그인 만료, 로그인 연장 처리 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seoye0ng
added
✨ Feature
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
seoye0ng
changed the title
seoye0ng
changed the title
bottlewook
requested changes
Feb 20, 2024
| }), | ||
|
|
||
| /* ----- refresh token api success ----- */ | ||
| http.post(`${process.env.NEXT_PUBLIC_BASE_URL}/auth/validToken`, () => { |
There was a problem hiding this comment.
이거 두개로 나누지 않고 조건문으로 분기 처리할 수 있지 않나요?
| @@ -24,6 +24,12 @@ export const login = async ({ | |||
| return response; | |||
| }; | |||
|
|
|||
| export const refreshToken = async () => { | |||
| const response = await postRequest<RefreshTokenType, null>('/auth/validToken'); | |||
There was a problem hiding this comment.
이 api는 지용님이 만들어주실 예정인가요?
There was a problem hiding this comment.
아마 그러실 것 같아요. 개발 예정이라고 하셨습니다!
|
|
||
| import { useMutation } from '@tanstack/react-query'; | ||
|
|
||
| import useLoggedOut from '@/hooks/useLoggedOut'; |
There was a problem hiding this comment.
Suggested change
| import useLoggedOut from '@/hooks/useLoggedOut'; | |
| import useLoggedOut from '@hooks/useLoggedOut'; |
| }; | ||
|
|
||
| const onError = () => { | ||
| handleLogout('/login'); |
There was a problem hiding this comment.
다시 로그인 해주세요 표시를 토스트로 보여줘도 될 것 같네요
하나 만들겠습니다!
src/hooks/useIntervalRefreshToken.ts
Outdated
| @@ -0,0 +1,22 @@ | |||
| import useRefreshToken from '@remote/queries/auth/useRefreshToken'; | |||
|
|
|||
| const JWT_EXPIRY_TIME = 15 * 60 * 1000; | |||
There was a problem hiding this comment.
서버 토큰 만료 시간이 15분이라 14분으로 맞춰도 될 것 같아요!
|
|
||
| useEffect(() => { | ||
| if (userId !== null) { | ||
| startRefreshTokenInterval(); |
There was a problem hiding this comment.
기존에 가지고 있던 토큰을 이용해서 새로운 토큰을 발급 받을 예정이신거죠?
There was a problem hiding this comment.
넵 지용님이랑 얘기해봤는데 헤더 Authentication에 담아 보내주면 body에 새로운 토큰을 넣어서 보내주신다고 하십니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers
아직 api가 완성되지 않아 mock data 작성해서 진행했습니다.